Update cuenca-validations to version 2.1.31.dev0, increment internal …#440
Open
rcabrera-py wants to merge 2 commits intomainfrom
Open
Update cuenca-validations to version 2.1.31.dev0, increment internal …#440rcabrera-py wants to merge 2 commits intomainfrom
rcabrera-py wants to merge 2 commits intomainfrom
Conversation
…version to 2.1.20.dev0, and add PasswordReset resource with tests.
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughAdds a PasswordReset resource class (creatable, retrievable, queryable) with fields, JSON schema example, and a create(location) API. Exposes PasswordReset in package exports and registers it in resources. Updates SANDBOX_HOST to api.cuenca.com, bumps version to 2.1.20.dev1, updates cuenca-validations to 2.1.31.dev1, and adds pytest tests for create/retrieve/list flows. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cuenca/http/client.py`:
- Line 21: SANDBOX_HOST is incorrectly set to the same value as API_HOST so
configure(sandbox=True) doesn't switch environments; restore a distinct sandbox
hostname by changing the SANDBOX_HOST assignment (symbol SANDBOX_HOST in
cuenca/http/client.py) back to the sandbox-specific host used by the service and
ensure configure(sandbox=True) uses SANDBOX_HOST instead of API_HOST (refer to
the configure(sandbox=True) logic and any host-selection code that reads
API_HOST/SANDBOX_HOST).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f579c9db-d1a0-4fa8-a059-4ca9028b44df
📒 Files selected for processing (7)
cuenca/__init__.pycuenca/http/client.pycuenca/resources/__init__.pycuenca/resources/password_resets.pycuenca/version.pyrequirements.txttests/resources/test_password_resets.py
|
|
||
| API_HOST = 'api.cuenca.com' | ||
| SANDBOX_HOST = 'sandbox.cuenca.com' | ||
| SANDBOX_HOST = 'api.cuenca.com' |
There was a problem hiding this comment.
Restore a distinct sandbox host for sandbox mode.
Line 21 makes SANDBOX_HOST equal to API_HOST, so configure(sandbox=True) no longer changes environment. This collapses sandbox/prod separation and matches the observed 403 failures in password reset tests.
🔧 Proposed fix
API_HOST = 'api.cuenca.com'
-SANDBOX_HOST = 'api.cuenca.com'
+SANDBOX_HOST = 'sandbox.cuenca.com'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@cuenca/http/client.py` at line 21, SANDBOX_HOST is incorrectly set to the
same value as API_HOST so configure(sandbox=True) doesn't switch environments;
restore a distinct sandbox hostname by changing the SANDBOX_HOST assignment
(symbol SANDBOX_HOST in cuenca/http/client.py) back to the sandbox-specific host
used by the service and ensure configure(sandbox=True) uses SANDBOX_HOST instead
of API_HOST (refer to the configure(sandbox=True) logic and any host-selection
code that reads API_HOST/SANDBOX_HOST).
…_id from PasswordReset resource, and adjust related tests.
rcabrera-py
force-pushed
the
feat/add-reset-password
branch
from
ea039ae to
8663f46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…version to 2.1.20.dev0, and add PasswordReset resource with tests.
Summary by CodeRabbit
New Features
Chores
Tests